[Lldb-commits] [PATCH] D28944: Provide option to set pc of the file loaded in memory.

[Greg Clayton via Phabricator via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just set an error when "set_pc" is true and you get no entry point back from thee object file and this is good to go.



================
Comment at: source/Symbol/ObjectFile.cpp:685-686
+    Address file_entry = GetEntryPointAddress();
+    if (file_entry.IsValid())
+      reg_context->SetPC(file_entry.GetLoadAddress(&target));
+  }
----------------
Set an error if there is no valid entry point address. This would happen if someone tries to run load on a shared library.


https://reviews.llvm.org/D28944