[Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid created this revision.
omjavaid added reviewers: tfiala, labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.

TestRegisterVariables fails with https://reviews.llvm.org/owners/package/1/ level when using gcc version 5.0 or above on arm/arm64 linux targets.

The reason is injection of buffer overflow protection code at O level 1. This patch turns off buffer overflow protection code by turning off FORTIFY_SOURCE.

Can we commit this if nothing goes wrong on any other target. ?


https://reviews.llvm.org/D28666

Files:
  packages/Python/lldbsuite/test/lang/c/register_variables/Makefile


Index: packages/Python/lldbsuite/test/lang/c/register_variables/Makefile
===================================================================
--- packages/Python/lldbsuite/test/lang/c/register_variables/Makefile
+++ packages/Python/lldbsuite/test/lang/c/register_variables/Makefile
@@ -2,6 +2,6 @@
 
 C_SOURCES := test.c
 
-CFLAGS_EXTRAS += -O1
+CFLAGS_EXTRAS += -O1 -D_FORTIFY_SOURCE=0
 
 include $(LEVEL)/Makefile.rules


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28666.84257.patch
Type: text/x-patch
Size: 421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170113/b9b3bdef/attachment.bin>