[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 10 14:38:32 PST 2017

clayborg added a comment.

You can't add anything extra to the AsCString() since it returns a "const char *". You can't return a StringRef because it isn't backed by anything. You could return a std::string.

My vote would be to leave AsCString() alone and have it just return a pointer to the string buffer that it owns, and let the formatv stuff do the extra formatting.


More information about the lldb-commits mailing list