[Lldb-commits] [PATCH] D28466: Improve Type::GetTypeScopeAndBasenameHelper and add unit tests

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Fix the consume_front mentioned in the inlined comment and this is good to go.



================
Comment at: source/Core/Module.cpp:1010-1011
 
     if (type_scope.size() >= 2 && type_scope[0] == ':' &&
         type_scope[1] == ':') {
+      type_scope = type_scope.drop_back(2);
----------------
Use consume_front here:

```
if (type_scope.consume_front("::"))
  exact_match = true;
```


https://reviews.llvm.org/D28466