[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 5 08:10:42 PST 2017

labath added a comment.

I've done a bit of investigation, and there is still a lot of `FILE*` usage in random places. I believe most of them would be pretty easy to get rid of (https://reviews.llvm.org/D28356 is one of the more complicated cases).

However, the main problem I see is the SB API, which uses FILE* in a couple of places (SBDebugger, SBCommandReturnObject, and a couple others).  While we can make sure that we use a single api consistently for all the FILE* that are passed to us, we cannot guarantee anything if the user expects to be able to access the FILE* objects while we are using them.

With that in mind I still think we should go ahead with the standardization, as we are not very consistent to begin with. This way we can be at least internally consistent in our usage, and the API boundary problem can be resolved in SBv2.

Let me know what you think.


More information about the lldb-commits mailing list