[Lldb-commits] [PATCH] D28233: Improve the performance of jModulesInfo in lldb-server

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks great, thanks.

Do you have any measurements on the real impact this makes on jModulesInfo packet?



================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1757
+  // one memory region if memory region handling is supported.
+  if (m_mem_region_cache.empty()) {
+    Error error = ProcFileReader::ProcessLineByLine(
----------------
Please put an early return here:
`if (!cache.empty() { log_if_you_want_to(); return Error(); }`


https://reviews.llvm.org/D28233