[Lldb-commits] [PATCH] D27759: Fix build for mingw.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I'll leave Zachary to approve, but it seems reasonable.

BTW, I am curious, are you planning on building python with mingw as well? If you are, I'd be interested in knowing how that works out.



================
Comment at: cmake/modules/LLDBConfig.cmake:246
+if (MSVC)
+    add_definitions( /D _UNICODE /D UNICODE )
+elseif (MINGW)
----------------
Could you check if it's enough to pass `-DFOO` regardless of the platform. This is the only usage of the `/D` version in the llvm codebase, which leads me to believe that msvc will accept the `-D` version as well (or cmake will somehow convert in for him.


================
Comment at: source/Core/Mangled.cpp:12
 #include <cstddef>
-#if defined(_MSC_VER)
+#if defined(_WIN32)
 #include "lldb/Host/windows/windows.h"
----------------
Should we use LLVM_ON_WIN32 here? That seems to be the llvm preffered solution...


https://reviews.llvm.org/D27759