[Lldb-commits] [lldb] r289644 - Remove code needed for supporting old VS versions.

Hafiz Abid Qadeer via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 14 03:13:03 PST 2016


Author: abidh
Date: Wed Dec 14 05:13:03 2016
New Revision: 289644

URL: http://llvm.org/viewvc/llvm-project?rev=289644&view=rev
Log:
Remove code needed for supporting old VS versions.

Summary: This code was probably needed to support VS2013 and is not needed now. I have built it with VS and mingw. Ok to remove it?

Reviewers: zturner, abidh

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D27707

Modified:
    lldb/trunk/include/lldb/Host/windows/PosixApi.h

Modified: lldb/trunk/include/lldb/Host/windows/PosixApi.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/windows/PosixApi.h?rev=289644&r1=289643&r2=289644&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Host/windows/PosixApi.h (original)
+++ lldb/trunk/include/lldb/Host/windows/PosixApi.h Wed Dec 14 05:13:03 2016
@@ -75,15 +75,6 @@ typedef uint32_t pid_t;
 
 #endif // _MSC_VER
 
-// MSVC 2015 and higher have timespec.  Otherwise we need to define it
-// ourselves.
-#if !defined(_MSC_VER) || _MSC_VER < 1900
-struct timespec {
-  time_t tv_sec;
-  long tv_nsec;
-};
-#endif
-
 // Various useful posix functions that are not present in Windows.  We provide
 // custom implementations.
 int vasprintf(char **ret, const char *fmt, va_list ap);
@@ -113,20 +104,4 @@ inline char *ptsname(int fd) { LLVM_BUIL
 inline pid_t fork(void) { LLVM_BUILTIN_UNREACHABLE; }
 inline pid_t setsid(void) { LLVM_BUILTIN_UNREACHABLE; }
 
-// vsnprintf and snprintf are provided in MSVC 2015 and higher.
-#if _MSC_VER < 1900
-namespace lldb_private {
-int vsnprintf(char *buffer, size_t count, const char *format, va_list argptr);
-}
-
-// inline to avoid linkage conflicts
-int inline snprintf(char *buffer, size_t count, const char *format, ...) {
-  va_list argptr;
-  va_start(argptr, format);
-  int r = lldb_private::vsnprintf(buffer, count, format, argptr);
-  va_end(argptr);
-  return r;
-}
-#endif
-
 #endif




More information about the lldb-commits mailing list