[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

Ted Woodward via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 5 10:05:52 PST 2016


ted added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2590
+            (arch.GetTriple().isOSBinFormatELF() ||
              arch.GetMachine() == llvm::Triple::hexagon)) {
           SymbolContextList temp_sc_list;
----------------
clayborg wrote:
> labath wrote:
> > I think we can remove the hexagon part as well. Ted, I presume hexagon uses ELF files?
> I believe Hexagon uses ELF so it would be ok to remove the Hexagon from the if.
Yes, Hexagon uses ELF, so this change should be fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D27380





More information about the lldb-commits mailing list