[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp
Filipe Cabecinhas via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 2 12:15:41 PST 2016
.Case("stack-use-after-return", "Use of returned stack memory")
Maybe "Use of stack memory after (function) return"? (i couldn't decide
whether to include "function". Either delete it or delete the parens.
This is a very minor nit, so I'm ok with keeping the current wording if you
prefer that.
On Fri, 2 Dec 2016 at 20:04, Kuba (Brecka) Mracek via Phabricator <
reviews at reviews.llvm.org> wrote:
> kubabrecka added a comment.
>
>
>
> In https://reviews.llvm.org/D27017#611894, @filcab wrote:
>
>
>
> > LGTM
>
> >
>
> > (I commented on a minor nit. It might just be me, so feel free to keep
> the current wording if you feel it's preferred)
>
>
>
>
>
> I'm not seeing this comment. Can you post it again?
>
>
>
>
>
> https://reviews.llvm.org/D27017
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161202/704f9e79/attachment.html>
More information about the lldb-commits
mailing list