[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer added inline comments.


================
Comment at: include/lldb/Core/RegularExpression.h:34
 #else
-#if __ANDROID_NDK__
+#if ANDROID
 #include <regex>
----------------
In most case you use "#ifdef". It would be nice to uniformalize


================
Comment at: source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp:31
 
-#if __ANDROID_NDK__
+#if ANDROID
 #include <sys/types.h>
----------------
In most case you use "#ifdef". It would be nice to uniformalize


================
Comment at: source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp:123
     !defined(_MSC_VER) && !defined(__mips__) && !defined(__powerpc__) &&       \
-    !defined(__ANDROID_NDK__)
+    !defined(ANDROID)
     case sizeof(long double):
----------------
(unrelated): What does an ANDROID specific define do in a MacOSX specific file?


https://reviews.llvm.org/D27305