[Lldb-commits] [PATCH] D27291: Handle UTF-16 and UTF-32 constant CFStrings

[Sean Callanan via Phabricator via lldb-commits]

spyffe created this revision.
spyffe added a reviewer: jingham.
spyffe added a subscriber: LLDB.
spyffe set the repository for this revision to rL LLVM.

We have a longstanding issue where the expression parser does not handle wide CFStrings (e.g., `@"凸凹"`) correctly, producing the useless error message

  Internal error [IRForTarget]: An Objective-C constant string's string initializer is not an array
  error: warning: expression result unused
  error: The expression could not be prepared to run in the target

This is just a side effect of the fact that we don't handle wide string constants when converting these to `CFStringCreateWithBytes`.  That function takes the string's encoding as an argument, so I made it work and added a testcase.


Repository:
  rL LLVM

https://reviews.llvm.org/D27291

Files:
  packages/Python/lldbsuite/test/lang/objc/unicode-string/TestUnicodeString.py
  packages/Python/lldbsuite/test/lang/objc/unicode-string/main.m
  source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27291.79847.patch
Type: text/x-patch
Size: 6303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161201/b1c52d4a/attachment.bin>