[Lldb-commits] [PATCH] D27136: Use Timeout<> in the Listener class

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 25 09:01:17 PST 2016


labath created this revision.
labath added reviewers: jingham, clayborg, zturner.
labath added a subscriber: lldb-commits.

Communication classes use the Timeout<> class to specify the timeout. Listener
class was converted to chrono some time ago, but it used a different meaning for
a timeout of zero (Listener: infinite wait, Communication: no wait). Instead,
Listener provided separate functions which performed a non-blocking event read.

This converts the Listener class to the new Timeout class, to improve
consistency. It also allows us to get merge the different GetNextEvent*** and
WaitForEvent*** functions into one. No functional change intended.


https://reviews.llvm.org/D27136

Files:
  include/lldb/Core/Listener.h
  source/API/SBDebugger.cpp
  source/API/SBListener.cpp
  source/Core/Communication.cpp
  source/Core/Debugger.cpp
  source/Core/IOHandler.cpp
  source/Core/Listener.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/Process.cpp
  unittests/Core/BroadcasterTest.cpp
  unittests/Core/ListenerTest.cpp
  unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27136.79313.patch
Type: text/x-patch
Size: 29583 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161125/0bc32323/attachment-0001.bin>


More information about the lldb-commits mailing list