[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

[Kuba Brecka via lldb-commits]

kubabrecka added a comment.

Thanks for these comments, I'll have them run by more people before committing this (I'm not a native English speaker).  These really need to be as user-focused as possible, so I'm really against stuff like "not owned pointer", because that's not something we should expect the user to understand.  Also note that we're not using these as a replacement of full reports, we're showing them as a quick description in addition to ASan reports.



================
Comment at: source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp:220
+  } else if (description == "stack-overflow") {
+    return "Stack overflow detected (recursion too deep)";
+  } else if (description == "null-deref") {
----------------
filcab wrote:
> Not necessarily recursion. There's also stack variables. I'd omit the stuff in parenthesis.
Multiple times have I seen that people read "stack overflow" as "stack **buffer** overflow" and they spend a lot of time trying to find what buffer was actually overflown...  I'd like to somehow point that out.  Ideas?


Repository:
  rL LLVM

https://reviews.llvm.org/D27017