[Lldb-commits] [PATCH] D27010: Refactor LLDB's Windows process plugin (NFC)

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 22 15:53:57 PST 2016


amccarth created this revision.
amccarth added reviewers: zturner, labath.
amccarth added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.

The Windows process plugin was broken up into multiple pieces a while back in order to share code between debugging live processes and minidumps (postmortem) debugging.  The minidump portion was replaced by a cross-platform solution.  This left the plugin split into a formerly "common" base classes and the derived classes for live debugging.  This extra layer made the code harder to understand and work with.

This patch simplifies these class hierarchies by rolling the live debugging concrete classes up to the base classes.  Last week I posted my intent to make this change to lldb-dev, and I didn't hear any objections.

This involved moving code and changing references to classes like ProcessWindowsLive to ProcessWindows.  It still builds for both 32- and 64-bit, and the tests still pass on 32-bit.  (Tests on 64-bit weren't passing before this refactor for unrelated reasons.)  I don't expect a thorough review; I'm posting this as a sanity check.

A subsequent patch will eliminate the unnecessary "Common" subdirectory.


https://reviews.llvm.org/D27010

Files:
  cmake/LLDBDependencies.cmake
  source/API/SystemInitializerFull.cpp
  source/Plugins/Process/CMakeLists.txt
  source/Plugins/Process/Windows/Common/CMakeLists.txt
  source/Plugins/Process/Windows/Common/DebuggerThread.cpp
  source/Plugins/Process/Windows/Common/DebuggerThread.h
  source/Plugins/Process/Windows/Common/ForwardDecl.h
  source/Plugins/Process/Windows/Common/IDebugDelegate.h
  source/Plugins/Process/Windows/Common/LocalDebugDelegate.cpp
  source/Plugins/Process/Windows/Common/LocalDebugDelegate.h
  source/Plugins/Process/Windows/Common/ProcessWindows.cpp
  source/Plugins/Process/Windows/Common/ProcessWindows.h
  source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
  source/Plugins/Process/Windows/Common/TargetThreadWindows.h
  source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp
  source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.h
  source/Plugins/Process/Windows/Live/CMakeLists.txt
  source/Plugins/Process/Windows/Live/DebuggerThread.cpp
  source/Plugins/Process/Windows/Live/DebuggerThread.h
  source/Plugins/Process/Windows/Live/ForwardDecl.h
  source/Plugins/Process/Windows/Live/IDebugDelegate.h
  source/Plugins/Process/Windows/Live/LocalDebugDelegate.cpp
  source/Plugins/Process/Windows/Live/LocalDebugDelegate.h
  source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
  source/Plugins/Process/Windows/Live/ProcessWindowsLive.h
  source/Plugins/Process/Windows/Live/TargetThreadWindowsLive.cpp
  source/Plugins/Process/Windows/Live/TargetThreadWindowsLive.h
  source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.cpp
  source/Plugins/Process/Windows/Live/x64/RegisterContextWindowsLive_x64.h
  source/Plugins/Process/Windows/Live/x86/RegisterContextWindowsLive_x86.cpp
  source/Plugins/Process/Windows/Live/x86/RegisterContextWindowsLive_x86.h
  source/Plugins/Process/Windows/MiniDump/CMakeLists.txt
  source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
  source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h
  source/Plugins/Process/Windows/MiniDump/ThreadWinMiniDump.cpp
  source/Plugins/Process/Windows/MiniDump/ThreadWinMiniDump.h
  source/Plugins/Process/Windows/MiniDump/x64/RegisterContextWindowsMiniDump_x64.cpp
  source/Plugins/Process/Windows/MiniDump/x64/RegisterContextWindowsMiniDump_x64.h
  source/Plugins/Process/Windows/MiniDump/x86/RegisterContextWindowsMiniDump_x86.cpp
  source/Plugins/Process/Windows/MiniDump/x86/RegisterContextWindowsMiniDump_x86.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27010.78968.patch
Type: text/x-patch
Size: 223424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161122/a056ad4f/attachment-0001.bin>


More information about the lldb-commits mailing list