[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 21 14:32:16 PST 2016
zturner added a comment.
Instead of storing the quote char, I think we could just store two `StringRef`s. `str` and `quoted_str`, where `str = quoted_str.trim(quote_char);`, and if there is no quote char, then they are equal. I'd rather do that in a followup since this `ArgEntry` class has already been here for some time and is kind of orthogonal to what's going on here, but it seems like a sane approach, as then you don't have to worry about anyone reconstructing the quoted version from the unquoted version, it's just already there.
https://reviews.llvm.org/D26883
More information about the lldb-commits
mailing list