[Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

[Todd Fiala via lldb-commits]

Hey Zachary,

I had to run home unexpectedly. The build worked but I left before the test
results came out.

If you ran it on Linux and the Linux tests passed, we can address issues
that show up on the macOS side.

I will also try it at home on macOS, but I don't think you need to hold up
with the aforementioned caveat on running the Linux tests.

On Wednesday, November 16, 2016, Zachary Turner <zturner at google.com> wrote:

> Hey Todd, Did you run the tests earlier?  If so what was the result?  No
> worries if you didn't run them yet, but it sounded like you were already
> kicking it off at 11:30.  Just want to make sure you didn't finish and
> forget to update with the result :)
>
> On Wed, Nov 16, 2016 at 12:38 PM Todd Fiala <todd.fiala at gmail.com
> <javascript:_e(%7B%7D,'cvml','todd.fiala at gmail.com');>> wrote:
>
>> Yep - I followed that.  I'm just doing the "build + test" verification on
>> macOS.
>>
>>
>> On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner <zturner at google.com
>> <javascript:_e(%7B%7D,'cvml','zturner at google.com');>> wrote:
>>
>>> BTW, I would still like to get Chris to take a look at my usage of
>>> llvm::Twine.  Even if it works, I'm not sure if I used it correctly.
>>>
>>> On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner <zturner at google.com
>>> <javascript:_e(%7B%7D,'cvml','zturner at google.com');>> wrote:
>>>
>>>> Either way is fine, I think you might have hit a merge conflict if you
>>>> stacked them, but if you've already worked through it, then no big deal.
>>>>
>>>> On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala <todd.fiala at gmail.com
>>>> <javascript:_e(%7B%7D,'cvml','todd.fiala at gmail.com');>> wrote:
>>>>
>>>>> tfiala added a comment.
>>>>>
>>>>> I'm going to test this one now, stacked on top of the final
>>>>> macOS-working version of https://reviews.llvm.org/D26698.  Tell me
>>>>> now if you want it tested independently of https://reviews.llvm.org/
>>>>> D26698.
>>>>>
>>>>>
>>>>> https://reviews.llvm.org/D26721
>>>>>
>>>>>
>>>>>
>>>>>
>>
>>
>> --
>> -Todd
>>
>

-- 
-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161116/9fab9038/attachment.html>