[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 16 13:25:55 PST 2016 

This revision was automatically updated to reflect the committed changes.
Closed by commit rL287152: Don't allow direct access to StreamString's internal buffer. (authored by zturner).

Changed prior to commit:
  https://reviews.llvm.org/D26698?vs=78068&id=78253#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D26698

Files:
  lldb/trunk/include/lldb/Core/Error.h
  lldb/trunk/include/lldb/Core/Log.h
  lldb/trunk/include/lldb/Core/StreamGDBRemote.h
  lldb/trunk/include/lldb/Core/StreamString.h
  lldb/trunk/include/lldb/DataFormatters/FormatClasses.h
  lldb/trunk/include/lldb/Host/Host.h
  lldb/trunk/include/lldb/Interpreter/CommandReturnObject.h
  lldb/trunk/include/lldb/Target/Process.h
  lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
  lldb/trunk/source/API/SBCommandReturnObject.cpp
  lldb/trunk/source/API/SBFrame.cpp
  lldb/trunk/source/API/SBStream.cpp
  lldb/trunk/source/API/SBTarget.cpp
  lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
  lldb/trunk/source/Commands/CommandObjectCommands.cpp
  lldb/trunk/source/Commands/CommandObjectHelp.cpp
  lldb/trunk/source/Commands/CommandObjectMemory.cpp
  lldb/trunk/source/Commands/CommandObjectMultiword.cpp
  lldb/trunk/source/Commands/CommandObjectProcess.cpp
  lldb/trunk/source/Commands/CommandObjectQuit.cpp
  lldb/trunk/source/Commands/CommandObjectTarget.cpp
  lldb/trunk/source/Commands/CommandObjectThread.cpp
  lldb/trunk/source/Commands/CommandObjectType.cpp
  lldb/trunk/source/Core/Address.cpp
  lldb/trunk/source/Core/DataExtractor.cpp
  lldb/trunk/source/Core/Debugger.cpp
  lldb/trunk/source/Core/Disassembler.cpp
  lldb/trunk/source/Core/EmulateInstruction.cpp
  lldb/trunk/source/Core/Error.cpp
  lldb/trunk/source/Core/Event.cpp
  lldb/trunk/source/Core/FormatEntity.cpp
  lldb/trunk/source/Core/IOHandler.cpp
  lldb/trunk/source/Core/Log.cpp
  lldb/trunk/source/Core/Module.cpp
  lldb/trunk/source/Core/RegisterValue.cpp
  lldb/trunk/source/Core/StreamString.cpp
  lldb/trunk/source/Core/StringList.cpp
  lldb/trunk/source/Core/StructuredData.cpp
  lldb/trunk/source/Core/ValueObject.cpp
  lldb/trunk/source/DataFormatters/FormatManager.cpp
  lldb/trunk/source/DataFormatters/TypeCategory.cpp
  lldb/trunk/source/DataFormatters/TypeFormat.cpp
  lldb/trunk/source/DataFormatters/TypeSummary.cpp
  lldb/trunk/source/DataFormatters/ValueObjectPrinter.cpp
  lldb/trunk/source/DataFormatters/VectorType.cpp
  lldb/trunk/source/Expression/IRExecutionUnit.cpp
  lldb/trunk/source/Expression/LLVMUserExpression.cpp
  lldb/trunk/source/Expression/Materializer.cpp
  lldb/trunk/source/Host/macosx/Host.mm
  lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
  lldb/trunk/source/Host/windows/Host.cpp
  lldb/trunk/source/Interpreter/Args.cpp
  lldb/trunk/source/Interpreter/CommandAlias.cpp
  lldb/trunk/source/Interpreter/CommandInterpreter.cpp
  lldb/trunk/source/Interpreter/CommandObject.cpp
  lldb/trunk/source/Interpreter/CommandReturnObject.cpp
  lldb/trunk/source/Interpreter/OptionValueEnumeration.cpp
  lldb/trunk/source/Interpreter/OptionValueLanguage.cpp
  lldb/trunk/source/Interpreter/Options.cpp
  lldb/trunk/source/Interpreter/Property.cpp
  lldb/trunk/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
  lldb/trunk/source/Plugins/ABI/SysV-arm64/ABISysV_arm64.cpp
  lldb/trunk/source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp
  lldb/trunk/source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp
  lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp
  lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp
  lldb/trunk/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp
  lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
  lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
  lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
  lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
  lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/trunk/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxx.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxList.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
  lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp
  lldb/trunk/source/Plugins/Language/Go/GoFormatterFunctions.cpp
  lldb/trunk/source/Plugins/Language/Java/JavaFormatterFunctions.cpp
  lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp
  lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
  lldb/trunk/source/Plugins/Language/ObjC/NSIndexPath.cpp
  lldb/trunk/source/Plugins/Language/ObjC/NSSet.cpp
  lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
  lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp
  lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  lldb/trunk/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp
  lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp
  lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
  lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
  lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
  lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp
  lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
  lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp
  lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
  lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp
  lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp
  lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  lldb/trunk/source/Symbol/ObjectFile.cpp
  lldb/trunk/source/Target/Process.cpp
  lldb/trunk/source/Target/StackFrame.cpp
  lldb/trunk/source/Target/StopInfo.cpp
  lldb/trunk/source/Target/Target.cpp
  lldb/trunk/source/Target/TargetList.cpp
  lldb/trunk/source/Target/Thread.cpp
  lldb/trunk/source/Target/ThreadPlanCallFunction.cpp
  lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp
  lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp
  lldb/trunk/tools/argdumper/argdumper.cpp
  lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26698.78253.patch
Type: text/x-patch
Size: 153755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161116/88b0b4ca/attachment-0001.bin>

More information about the lldb-commits mailing list