[Lldb-commits] [PATCH] D26698: Remove SBStream accessor that lets you manipulate the internal buffer.

[Zachary Turner via lldb-commits]

What revision should I apply this on top of?  It doesn't apply cleanly for
me at tip.  I think it's my fault because of the original patch, but now
I'm having trouble getting this modified patch to work.  Can you give me a
diff that I can apply on top of my original patch, which is applied on a
clean repo?  So ToT > ::my original patch:: > ::your set of fixes::, and
just give me your set of fixes?

On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner <zturner at google.com> wrote:

> Sweet.  Glad to see that such a large patch had only minor implications.
> Thanks for the help!
>
> On Wed, Nov 16, 2016 at 11:28 AM Todd Fiala <todd.fiala at gmail.com> wrote:
>
> tfiala accepted this revision.
> tfiala added a comment.
> This revision is now accepted and ready to land.
>
> Here is the adjusted patch that fixes the issue I was seeing on
> TestTerminal.py.  My first set of changes had a lifetime issue where I
> needed a const char* that was synthesized on the fly and went away by the
> time I needed it.
>
> LGTM on macOS with this patch applied:
> F2590224: D26698_macos_build_fixes_v2.diff <
> https://reviews.llvm.org/F2590224>
>
>
> https://reviews.llvm.org/D26698
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161116/404ac66f/attachment.html>