[Lldb-commits] [PATCH] D26721: Make AutoComplete code use StringRef

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 15 17:12:58 PST 2016


zturner created this revision.
zturner added reviewers: beanz, tfiala.
zturner added a subscriber: lldb-commits.

As per the title.  beanz@, could you specifically look over my usage of `llvm::Twine`?  This is the first time I've used this class, and I'm not sure if I'm using it correctly / efficiently.


https://reviews.llvm.org/D26721

Files:
  include/lldb/Core/ArchSpec.h
  include/lldb/Core/PluginManager.h
  include/lldb/Core/StringList.h
  include/lldb/Interpreter/CommandCompletions.h
  include/lldb/Symbol/Variable.h
  include/lldb/Utility/NameMatches.h
  source/Commands/CommandCompletions.cpp
  source/Core/ArchSpec.cpp
  source/Core/PluginManager.cpp
  source/Core/StringList.cpp
  source/Interpreter/CommandObject.cpp
  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
  source/Symbol/Variable.cpp
  source/Utility/NameMatches.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26721.78110.patch
Type: text/x-patch
Size: 31360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161116/e52cc663/attachment-0001.bin>


More information about the lldb-commits mailing list