[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

[Stephane Sezer via lldb-commits]

sas added a comment.

Just a couple nits inline. Also, did you run `clang-format` on your change? I see some issues with `if`s and the associated parentheses.



================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:215
+  }
+  if (siginfo_signal_found == false) {
+    // If we don't have signal from SIGINFO use the signal from each threads
----------------
Nit: `if (!siginfo_signal_found)`.


================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:218
+    // PRSTATUS note.
+    if( prstatus_signal_found == true) {
+      for (std::vector<ThreadData>::iterator it = m_thread_data.begin();
----------------
Similar nit: `if (prstatus_signal_found)`.


https://reviews.llvm.org/D26676