[Lldb-commits] [PATCH] D26528: Fix uninitialized members.

[Zachary Turner via lldb-commits]

Maybe just inline the initializations so we don't have to repeat code
across multiple constructors?  i.e.

bool m_is_resolved = false;

in the header file.

On Thu, Nov 10, 2016 at 8:54 PM Sam McCall via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> sammccall created this revision.
> sammccall added a subscriber: lldb-commits.
>
> Fix uninitialized members.
>
>
> https://reviews.llvm.org/D26528
>
> Files:
>   source/Host/common/FileSpec.cpp
>   source/Target/Process.cpp
>
>
> Index: source/Target/Process.cpp
> ===================================================================
> --- source/Target/Process.cpp
> +++ source/Target/Process.cpp
> @@ -4581,7 +4581,7 @@
>        : IOHandler(process->GetTarget().GetDebugger(),
>                    IOHandler::Type::ProcessIO),
>          m_process(process), m_read_file(), m_write_file(write_fd, false),
> -        m_pipe() {
> +        m_pipe(), m_is_running(false) {
>      m_pipe.CreateNew(false);
>      m_read_file.SetDescriptor(GetInputFD(), false);
>    }
> Index: source/Host/common/FileSpec.cpp
> ===================================================================
> --- source/Host/common/FileSpec.cpp
> +++ source/Host/common/FileSpec.cpp
> @@ -278,8 +278,8 @@
>  }
>
>  FileSpec::FileSpec()
> -    : m_directory(), m_filename(),
> m_syntax(FileSystem::GetNativePathSyntax()) {
> -}
> +    : m_directory(), m_filename(), m_is_resolved(false),
> +      m_syntax(FileSystem::GetNativePathSyntax()) {}
>
>  //------------------------------------------------------------------
>  // Default constructor that can take an optional full path to a
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161111/250b1b64/attachment.html>