[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

[Pavel Labath via lldb-commits]

labath added a comment.

Looks great. Ed, do you want to give this a try run?



================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:113
+        self.assertTrue(target, VALID_TARGET)
+        process = target.LoadCore("fpr_sse_x86_64.core")
+
----------------
Please add "linux" to the core file names. We'll probably have freebsd versions of these as well..


================
Comment at: source/Plugins/Process/elf-core/RegisterContextPOSIXCore_x86_64.h:49
 private:
-  uint8_t *m_gpregset;
+  std::shared_ptr<uint8_t> m_gpregset;
+  std::shared_ptr<uint8_t> m_fpregset;
----------------
Could you use a unique_ptr instead? The data doesn't seem to be shared with anyone...


https://reviews.llvm.org/D26300