[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

[Jim Ingham via lldb-commits]

jingham added a comment.

This is fine with one comment on the text.



================
Comment at: SB-api-coding-rules.html:51-54
+                                        An example of this is the SBValue class.  Please note it is necessary for the Impl class to
+                                        not be a class embedded in the SB class, but rather should be a separate class that is not
+                                        present in the public lldb namespace.  Failure to do so leads to leakage of weak-linked symbols
+                                        in the SBAPI.
----------------
I think it's more straightforward to say:

Please note that you should not put this Impl class in the lldb namespace.  Failure to do so...

After all, it would be equally bad to have put it inside the "namespace lldb" but not in the class.



https://reviews.llvm.org/D26470