[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

[Pavel Labath via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D26300#587333, @emaste wrote:

> Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD support to make-core.sh -- just avoiding /bin/bash, and the core file handler check.


Great. I am glad the `_start` thingy works the same way on FreeBSD as well. I think this approach has a lot of potential. We probably don't want to check in zillions of core files, even if they are tiny, but it should enable us to do at least a basic smoke test of our changes on OS/hardware combinations we don't have access to.

> I think we should be able to rename this directory to elf-core, and rename the individual cores to e.g. linux-i386.core, etc.

I'll get to that on Monday, if you don't beat me to it. :)


https://reviews.llvm.org/D26300