[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

[Ed Maste via lldb-commits]

emaste added a comment.

We need to make sure this does not regress FreeBSD core handling -- I will test as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to generate FreeBSD core files as well (although note that we get ~2.5MB cores with default configuration, so tweaking malloc options will be necessary).

Please document how the core files were created (e.g. compiler invocation), perhaps as a comment in the source file.



================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:107
 
+    @skipIf(oslist=['windows'])
+    @skipIf(triple='^mips')
----------------
Curious, why are these skipped only on windows?


https://reviews.llvm.org/D26300