[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 1 08:38:52 PDT 2016


tfiala added inline comments.


================
Comment at: source/API/CMakeLists.txt:109
   else()
-    # Don't use an explicit export.  Instead, tell the linker to
-    # export all symbols.
----------------
> This does not affect affect the state of backtracing. The option to export all symbols could still stay there, and maybe could even be the default. 

But you eliminate it here, don't you?  (Maybe you just missed that I was also exporting the lldb_private symbols in the case of "LLDB_EXPORT_ALL_SYMBOLS:BOOL=YES"?)


https://reviews.llvm.org/D26188





More information about the lldb-commits mailing list