[Lldb-commits] [PATCH] D26193: Minidump plugin: Fix flaky test

Dimitar Vlahovski via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 1 08:32:19 PDT 2016


dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added subscribers: beanz, lldb-commits.

One of the tests was flaky, because similarly to
https://reviews.llvm.org/D18697 (https://reviews.llvm.org/rL265391) - if there is a process running
which is with the same PID as in the core file, the minidump
core file debugging will fail, because we get some information from the
running process.
The fix is routing the ProcessInfo requests through the Process class
and overriding it in ProcessMinidump to return correct data.


https://reviews.llvm.org/D26193

Files:
  packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
  source/Plugins/Process/minidump/ProcessMinidump.cpp
  source/Plugins/Process/minidump/ProcessMinidump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26193.76560.patch
Type: text/x-patch
Size: 9892 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161101/6a692cd6/attachment.bin>


More information about the lldb-commits mailing list