[Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

Rudy Pons via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 28 02:33:57 PDT 2016

There is no new failure in the tests in Debug version on MSVC 2015, however
a bunch of failures (~30) were masked on Release builds (the Test Methods
count went from 769 to 1188). All the failures were already presents in the
Debug builds (where the optimizer didn't mess up with the code due to
LLVM_UNREACHERABLE). So I suppose it's still ok?

(BTW, I don't have commit rights, so I will depend on someone to commit it)

On Fri, Oct 21, 2016 at 8:11 PM, Zachary Turner <zturner at google.com> wrote:

> zturner accepted this revision.
> zturner added a comment.
> This revision is now accepted and ready to land.
> LGTM as long as you've run the test suite and confirmed everything works.
> https://reviews.llvm.org/D25681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161028/c88d6c0b/attachment.html>

More information about the lldb-commits mailing list