[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

[Jason Molenda via lldb-commits]

jasonmolenda updated this revision to Diff 75977.
jasonmolenda added a comment.

I believe this rewrite of the original patch addresses Tamas' feedback (thanks Tamas!)  I dropped a lot of the changes in the original; I switch EmulateInstructionARM64 from using DWARF register numbering to use LLDB register numbering and I am using the numbers from lldb-arm64-register-enums.h.  I get the register definitions (size, etc) from RegisterInfos_arm64.h.

I also fix the original bug that I was doing this for - to recognize the callee saves of the floating point register spills.  And added a unit test to test for that.

Tamas, when you have a minute could you look at this again and let me know what you think?  Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D25864

Files:
  source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
  unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25864.75977.patch
Type: text/x-patch
Size: 34242 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161027/50cebd41/attachment-0001.bin>