[Lldb-commits] [PATCH] D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull

[Dimitar Vlahovski via lldb-commits]

dvlahovski added inline comments.


================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:67
+  // skip if the Minidump file is Windows generated, because we are still
+  // work-in-progress
+  if (!minidump_parser ||
----------------
labath wrote:
> Zach, Adrian: IIUC, the new plugin should generally have feature parity with the windows-only plugin. (Dimitar: could you say exactly what bits are missing?). You should be able to test out this plugin on windows minidumps by removing the windows check below.
> 
> After this goes in, we'll be looking to remove the windows-only plugin.
Yes, I think that now my plugin has full feature parity with the windows-only one.


https://reviews.llvm.org/D25905