[Lldb-commits] [lldb] r284893 - [Test Suite] Allow overriding codesign identity
Chris Bieneman via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 21 15:13:55 PDT 2016
Author: cbieneman
Date: Fri Oct 21 17:13:55 2016
New Revision: 284893
URL: http://llvm.org/viewvc/llvm-project?rev=284893&view=rev
Log:
[Test Suite] Allow overriding codesign identity
Summary: Not everyone names their code sign identity "lldb_codesign", so it is nice to allow this to be overridden.
Reviewers: zturner, tfiala
Subscribers: labath, mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D25714
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
lldb/trunk/test/CMakeLists.txt
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=284893&r1=284892&r2=284893&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Fri Oct 21 17:13:55 2016
@@ -481,6 +481,8 @@ def parseOptionsAndInitTestdirs():
# Shut off multiprocessing mode when test directories are specified.
configuration.no_multiprocess_test_runner = True
+ lldbtest_config.codesign_identity = args.codesign_identity
+
#print("testdirs:", testdirs)
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py?rev=284893&r1=284892&r2=284893&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py Fri Oct 21 17:13:55 2016
@@ -151,6 +151,11 @@ def create_parser():
dest='log_success',
action='store_true',
help="Leave logs/traces even for successful test runs (useful for creating reference log files during debugging.)")
+ group.add_argument(
+ '--codesign-identity',
+ metavar='Codesigning identity',
+ default='lldb_codesign',
+ help='The codesigning identity to use')
# Configuration options
group = parser.add_argument_group('Remote platform options')
Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=284893&r1=284892&r2=284893&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Fri Oct 21 17:13:55 2016
@@ -1543,8 +1543,8 @@ class Base(unittest2.TestCase):
def signBinary(self, binary_path):
if sys.platform.startswith("darwin"):
- codesign_cmd = "codesign --force --sign lldb_codesign %s" % (
- binary_path)
+ codesign_cmd = "codesign --force --sign \"%s\" %s" % (
+ lldbtest_config.codesign_identity, binary_path)
call(codesign_cmd, shell=True)
def findBuiltClang(self):
Modified: lldb/trunk/test/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists.txt?rev=284893&r1=284892&r2=284893&view=diff
==============================================================================
--- lldb/trunk/test/CMakeLists.txt (original)
+++ lldb/trunk/test/CMakeLists.txt Fri Oct 21 17:13:55 2016
@@ -85,6 +85,10 @@ if ( CMAKE_SYSTEM_NAME MATCHES "Windows"
endif()
endif()
+if(LLDB_CODESIGN_IDENTITY)
+ list(APPEND LLDB_TEST_COMMON_ARGS --codesign-identity "${LLDB_CODESIGN_IDENTITY}")
+endif()
+
add_python_test_target(check-lldb-single
${LLDB_SOURCE_DIR}/test/dotest.py
"--no-multiprocess;${LLDB_TEST_COMMON_ARGS};${LLDB_TEST_USER_ARGS}"
More information about the lldb-commits
mailing list