[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first
Chris Bieneman via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 20 09:26:06 PDT 2016
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
`LLDB_PATH_TO_LLVM_BUILD` is a swift-ism that doesn't match LLVM's CMake conventions. In LLVM we don't pass in the path to build directories, instead we pass in `LLVM_CONFIG` to standalone builds, and we derive the build directory from the output of `llvm-config`.
Passing in `LLVM_CONFIG` is more flexible, robust, and consistent with how other LLVM subprojects work, and I see no reason to change that convention.
More information about the lldb-commits