[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters
Tamas Berghammer via lldb-commits
lldb-commits at lists.llvm.org
Thu Oct 20 08:36:25 PDT 2016
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138
+ return 3;
+ return UINT32_MAX;
> I know you just copied it, but this seems wrong (size_t can be 64-bit). Will this work if you just return `~0`.
Actually as far as I can tell all use case of this API assumes it is a uint32_t and compares the return value against UINT32_MAX :(
I will just leave it as it is and then we should have a separate CL what cleans up the mess around it
More information about the lldb-commits