[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 19 07:00:40 PDT 2016

labath added a comment.

Just a couple of cleanups and then I think we're ready.

Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:78
+  if ((context_flags & ControlFlag) == ControlFlag) {
+    writeRegister(&context->cs, getDestRegister(result_base, lldb_cs_x86_64,
+                                                reg_info[lldb_cs_x86_64]));
These would be cleaner, if we made writeRegister call getDestRegister internally.
Then these two lines would become:
writeRegister(&context->cs, result_base, reg_info[lldb_cs_x86_64]);
Note that you don't have to pass in lldb_cs_x86_64 explicitly, as that information can be recovered via reg_info->kinds[eRegisterKindLLDB].

Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h:141
+      uint128_struct legacy[8];
+      uint128_struct xmm0;
+      uint128_struct xmm1;
labath wrote:
> `uint128_struct xmm[16];` ?
> I'm not that sure about that struct and it's name though, I'll need to think about that.
I don't really have a good idea about struct issue. Let's at least call it Uint128, so that it's consistent with the rest of the struct's in this class, and then call it a day.


More information about the lldb-commits mailing list