[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

[Pavel Labath via lldb-commits]

labath added a comment.

Looks fine with the usual comments. :)



================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile:5
+
+CXXFLAGS := -O0
+USE_LIBSTDCPP := 1
----------------
Same comments as the previous patch (no CXXFLAGS, simplify no-limit-debug-info handling)


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/TestDataFormatterStdUniquePtr.py:33
+
+        self.expect("frame variable nup", substrs=['nup = nullptr'])
+        self.expect("frame variable iup", substrs=['iup = 123', 'object = 123'])
----------------
Can you add a test accessing `nup.deleter`, `iup.deleter` (I guess they should error out?)


================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110
+  if (name == ConstString("ptr") || name == ConstString("pointer")) return 2;
+  return UINT32_MAX;
+}
----------------
~0 ?


https://reviews.llvm.org/D25734