[Lldb-commits] [PATCH] D25733: Add data formatter for libstdc++ tuple

[Pavel Labath via lldb-commits]

labath added a comment.

Just minor nits from my side.



================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile:5
+
+CXXFLAGS := -O0
+USE_LIBSTDCPP := 1
----------------
I don't think this is necessary.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/tuple/Makefile:8
+
+# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
+# targets.  Other targets do not, which causes this test to fail.
----------------
Replace with `CFLAGS_EXTRAS += $(NO_LIMIT_DEBUG_INFO_FLAGS)`


================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp:58
+
+  ValueObjectSP valobj_sp = valobj_backend_sp->GetNonSyntheticValue();
+  if (!valobj_sp) return false;
----------------
 


================
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppTuple.cpp:77
+          StreamString name;
+          name.Printf("[%" PRIu64 "]", m_members.size());
+          value_sp->SetName(ConstString(name.GetData()));
----------------
You can use %z now.


https://reviews.llvm.org/D25733