[Lldb-commits] [PATCH] debugserver: Disable four-char-constants and format-pedantic warnings
Justin Bogner via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 18 16:20:36 PDT 2016
Pavel Labath <labath at google.com> writes:
> Thanks for the patch. Could you submit the patch through phabricator
> <https://reviews.llvm.org> and add Greg Clayton as a reviewer.
Maybe later. I don't have time to fight with phabricator today.
> That said, my preference would be to actually fix those warnings
> instead of silencing them.
If you think that's best, but do note that neither of these warnings is
flagging much of a problem:
- The four-character-literal warning is flagging implementation defined
behaviour four spelling a 32 bit hex constant in ascii instead of
something like 0x46445343. This is a portability vs readability thing,
and pretty minor.
- The format-pedantic is warning about passing typed pointers to a %p
format specifier. The "fix" is to cast these arguments to `void *`,
which IMO hurts readability for no gain. I'm pretty sure this warning
only exists to preserve portability to some hypothetical ABI whose
calling convention depends on the type of the pointer.
> On 17 October 2016 at 08:24, Justin Bogner via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Today I checked out lldb to check that r284364 wouldn't cause any
>> trouble, but there were a few warnings that fired when I tried to build
>> it, breaking my -Werror build.
>> This disables four character literal warnings (so that 'FDSC' in
>> debugserver.cpp is allowed) and pedantic formatting warnings, so that
>> printf-like functions can pass typed pointers to "%p" in format strings.
>> Okay to commit?
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
More information about the lldb-commits