[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

Eugene Zelenko via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 18 10:24:41 PDT 2016

Eugene.Zelenko added a comment.

Please run Clang-format over new code.

Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:12
+#include <memory>
+#include <vector>
STL headers should be after application's headers.

Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:28
+class LibStdcppSharedPtrSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
+ public:
+  explicit LibStdcppSharedPtrSyntheticFrontEnd(lldb::ValueObjectSP valobj_sp);
No space before access specifiers. Same below.


More information about the lldb-commits mailing list