[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Oct 17 08:46:23 PDT 2016
labath added a comment.
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:61
+ if (source_data.size() < sizeof(MinidumpContext_x86_64))
+ return result_context_buf;
This looks like error handling. Should we return an empty buffer in that case (so that the caller can see that we actually failed in parsing this)?
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h:141
+ uint128_struct legacy;
+ uint128_struct xmm0;
+ uint128_struct xmm1;
`uint128_struct xmm;` ?
I'm not that sure about that struct and it's name though, I'll need to think about that.
More information about the lldb-commits