[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

Dimitar Vlahovski via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 17 07:40:32 PDT 2016

dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.

I misunderstood the format of the register context layout.
I thought it was a dynamically changing structure, and that it's size
depended on context_flags.
It turned out that it always has the same fixed layout and size,
and the context_flags says which fields of the
struct have valid values.
This required a minor redesign of the register context class.

The layout inconsistency, however, was not a "problem" before (e.g. the plugin was working)
because there also was a bug with checking context_flags - the code was
parsing the entire struct regardless of context_flags.
This bug is also fixed in this commit.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25677.74845.patch
Type: text/x-patch
Size: 18097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161017/9d3c40e7/attachment-0001.bin>

More information about the lldb-commits mailing list