[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

[Dimitar Vlahovski via lldb-commits]

dvlahovski added inline comments.


================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:222
+
+  if (header->size_of_header > sizeof(MinidumpMemoryInfoListHeader)) {
+    data = data.drop_front(header->size_of_header -
----------------
zturner wrote:
> I don't think you need the conditional here do you?  Just `data = data.drop_front(sizeof_MinidumpMemoryInfoListHeader)`.
`header->size_of_header` is >= `sizeof(MinidumpMemoryInfoListHeader)` here. So, yes, I can simplify it like this: `data = data.drop_front(header->size_of_header - sizeof(MinidumpMemoryInfoListHeader));`


https://reviews.llvm.org/D25569