[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

[Vadim Macagon via lldb-commits]

enlight marked an inline comment as done.
enlight added inline comments.


================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
   if (!bOk)
-    return m_pUnkwn;
+    return kUnresolvedValue;
 
----------------
ki.stfu wrote:
> After couple of minutes I see the lack of logic there: the value is still composite but we return kUnresolvedValue instead of kUnresolvedCompositeValue.
> 
> I think we have to rename kUnresolvedValue back to kUnknownValue.
Yep, good point, I've renamed it back.


Repository:
  rL LLVM

https://reviews.llvm.org/D25592