[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

[Ilia K via lldb-commits]

ki.stfu requested changes to this revision.
ki.stfu added inline comments.
This revision now requires changes to proceed.


================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116
   if (!bOk)
-    return m_pUnkwn;
+    return kUnresolvedValue;
 
----------------
After couple of minutes I see the lack of logic there: the value is still composite but we return kUnresolvedValue instead of kUnresolvedCompositeValue.

I think we have to rename kUnresolvedValue back to kUnknownValue.


Repository:
  rL LLVM

https://reviews.llvm.org/D25592