[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

[Vadim Macagon via lldb-commits]

enlight added inline comments.


================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22
 
+static const char *kUnknownValue = "??";
+static const char *kCompositeValuePlaceholder = "{...}";
+
----------------
ki.stfu wrote:
> use unnamed namespace here
I would like to use an anonymous namespace but the [[ http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | LLVM coding standards ]] say

> make anonymous namespaces as small as possible, and only use them for class declarations

I don't really buy their reasoning, but we are supposed to be following their style now aren't we?

kUnresolvedValue/kUnresolvedCompositeValue does sound better, I'll rename them.


Repository:
  rL LLVM

https://reviews.llvm.org/D25592