[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

[Kamil Rytarowski via lldb-commits]

krytarowski added inline comments.


================
Comment at: cmake/modules/LLDBConfig.cmake:414
+
+find_package(Backtrace REQUIRED)
----------------
tfiala wrote:
> Hi Sylvestre!
> 
> It's hard to tell without more context, but it looks like this location has most/all configurations going through it.  For OSes that don't actually have a backtrace package, I think this emits a cmake error, doesn't it?
> 
> This might need to be protected by the systems that need the backtrace package.  (Probably Unix-like systems only?)
It's sufficient to drop the `REQUIRED` keyword and it will be fine. `${Backtrace_LIBRARY}` will be evaluated to NIL in case of lack of this dependency.

I'm unsure whether `find_pacakge()` might be after usage of `${Backtrace_LIBRARY}`. I would reorder it at least for clarity for a reader.


https://reviews.llvm.org/D23977