[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

[Zachary Turner via lldb-commits]

zturner updated this revision to Diff 73554.
zturner added a comment.

Fixed up `ParseCanonicalReference` and `SplitIDRangeExpression` as suggested.  I could have probably returned an `Optional<std::pair<StringRef,StringRef>>` but it seemed like overkill.  An empty pair seems sufficient for conveying failure.


https://reviews.llvm.org/D25158

Files:
  include/lldb/Breakpoint/BreakpointID.h
  include/lldb/Breakpoint/BreakpointIDList.h
  source/Breakpoint/BreakpointID.cpp
  source/Breakpoint/BreakpointIDList.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25158.73554.patch
Type: text/x-patch
Size: 25229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161004/3e5f10bf/attachment-0001.bin>