[Lldb-commits] [PATCH] D25099: Refactor Args a different way

[Zachary Turner via lldb-commits]

Thanks, I'll fix it up before submitting
On Mon, Oct 3, 2016 at 2:40 PM Jim Ingham <jingham at apple.com> wrote:

> jingham added a comment.
>
> You messed up the meaning of one comment (noted inline).  Otherwise this
> looks fine to me too.
>
>
>
> > Args.cpp:97-98
> > +  // Argument can be split into multiple discontiguous pieces, for
> example:
> > +  //  "Hello " "World"
> > +  // this would result in a single argument "Hello World" (without the
> quotes)
> > +  // since the quotes would be removed and there is not space between
> the
>
> The example needs to be "Hello ""World" or it doesn't make sense.  "Hello
> " "World" with a space in between would be two arguments.
>
> https://reviews.llvm.org/D25099
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20161003/1d8e3541/attachment.html>