[Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

[Jim Ingham via lldb-commits]

These tests were failing for a bogus reason, so I fixed the bogus reason and let them try again.  They succeed on MacOS, but apparently there's another failure reason for these configurations.

Do you know the configuration for (in terms of the testsuite's "oslist"?  If not, I'll find out what to xfail.

Jim
 


> On Oct 3, 2016, at 3:12 AM, Dimitar Vlahovski <dvlahovski at google.com> wrote:
> 
> Hi,
> Are these build breakages somehow connected to this commit?
> http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8703
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/9655
> 
> Thanks,
> Dimitar
> 
> On Fri, Sep 30, 2016 at 11:07 PM, Jim Ingham via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> Author: jingham
> Date: Fri Sep 30 17:07:41 2016
> New Revision: 282966
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=282966&view=rev
> Log:
> IsValid is the way to ask a breakpoint location whether it is valid.
> 
> Modified:
>     lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py?rev=282966&r1=282965&r2=282966&view=diff
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py Fri Sep 30 17:07:41 2016
> @@ -27,7 +27,7 @@ class BreakpointCaseSensitivityTestCase(
> 
>      @skipIf(oslist=['windows'])  # Skip for windows platforms
>      # Failing for unknown reason on non-Windows platforms.
> -    @expectedFailureAll()
> +
>      def test_breakpoint_doesnt_match_file_with_different_case(self):
>          """Set breakpoint on file, shouldn't match files with different case on POSIX systems"""
>          self.build()
> @@ -98,7 +98,8 @@ class BreakpointCaseSensitivityTestCase(
>          # Get the breakpoint location from breakpoint after we verified that,
>          # indeed, it has one location.
>          location = breakpoint.GetLocationAtIndex(0)
> -        self.assertEqual(location and location.IsEnabled(),
> +
> +        self.assertEqual(location.IsValid(),
>                           should_hit,
>                           VALID_BREAKPOINT_LOCATION + desc)
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>