[Lldb-commits] [PATCH] D25099: Refactor Args a different way

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Sun Oct 2 08:55:41 PDT 2016


zturner added inline comments.


> labath wrote in Args.cpp:207
> I think we don't need to call Clear() here, as all memory owned by the object will be correctly destroyed anyway.

Thanks for pointing that out.  Originally I wasn't using `unique_ptr` but rather `new[]` and `delete[]`.  After I changed to `unique_ptr<char[]>` this became unnecessary and I forgot to remove it.  Thanks for pointing it out.

https://reviews.llvm.org/D25099





More information about the lldb-commits mailing list